Skip to content

Make multicluster CRD waits resilient - #2338

Open
kahirokunn wants to merge 1 commit into
knative:mainfrom
kahirokunn:agent/stabilize-crd-wait
Open

Make multicluster CRD waits resilient#2338
kahirokunn wants to merge 1 commit into
knative:mainfrom
kahirokunn:agent/stabilize-crd-wait

Conversation

@kahirokunn

@kahirokunn kahirokunn commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

kubectl wait --for=condition=Established can exit immediately when it sees the initial null conditions value. Polling the condition list avoids that race while keeping the existing timeout.

Release Note

NONE

@knative-prow

knative-prow Bot commented Aug 10, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026
@knative-prow

knative-prow Bot commented Aug 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign houshengbo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
knative-prow Bot requested review from aliok and matzew August 10, 2026 04:37
@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2026
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.89%. Comparing base (8f00498) to head (e2b1551).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2338   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files          55       55           
  Lines        2479     2479           
=======================================
  Hits         1584     1584           
  Misses        776      776           
  Partials      119      119

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kahirokunn
kahirokunn marked this pull request as ready for review August 10, 2026 04:46
@knative-prow knative-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026
@knative-prow
knative-prow Bot requested a review from houshengbo August 10, 2026 04:46
@kahirokunn

kahirokunn commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

/ok-to-test

@knative-prow knative-prow Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok Awaiting requested review from aliok
@matzew matzew Awaiting requested review from matzew
@houshengbo houshengbo Awaiting requested review from houshengbo

Assignees

No one assigned

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kahirokunn